Skip to content

Conversation

@HonzaKirchner
Copy link
Member

CleanShot 2024-11-13 at 09 56 26@2x

@github-actions github-actions bot added the t-c&c Team covering store and finance matters. label Nov 13, 2024
user-select: none;
}

.tsd-flag-group {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesnt look right, we already have margin on the group, its missing on tsd-flag

image image

for tsd-flag we want just margin-right, it has a negative top margin and you would override it this way

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm the screen above is parameters, but the one in OP is on higher level (method name). this will be probably more tricky, you will need to target this better most likely.

try to debug this directly on the SDK docs so you can see how things end up visually. you can run them separately.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh.. I see.
Should be fixed now ✅
CleanShot 2024-11-18 at 13 00 30@2x

@HonzaKirchner HonzaKirchner requested a review from B4nan November 18, 2024 12:02
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still feel like we will also need the tsd-flag margin which we have in the other repos, but let's deal with that once we see it.

@B4nan B4nan changed the title docs: space between header and flags added fix: space between header and flags added Nov 18, 2024
@B4nan B4nan merged commit 8f89e99 into master Nov 18, 2024
7 checks passed
@B4nan B4nan deleted the fix/flags-spacing branch November 18, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-c&c Team covering store and finance matters.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants